-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note about typical autocomplete combos for conditional UI #1992
Conversation
I'm not a huge fan of how the new Note renders, but I couldn't get it to indent one level closer to the left without tripping CI's HTML validator which complained that I tried to put a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
drive-by question: Why does the I'm happy the note is there. I just wonder why it's needed in the first place |
The autofill attribute has a grammar with a strict order that parses right-to-left [1]. [1] https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#autofill |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Approved.
- `"username webauthn"` | ||
- `"current-password webauthn"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add autofill=
to make the examples that tiny bit clearer, but this is fine as is too.
- `"username webauthn"` | |
- `"current-password webauthn"` | |
- `autofill="username webauthn"` | |
- `autofill="current-password webauthn"` |
If I understood the HTML spec right it seems like |
Yes, that should work too. Either pointing it out or not sounds good to me. |
I think it'd be better to encourage here more use of proper autofill tokens so I'm inclined to not call this otherwise valid combination out... |
Sounds fair. 🙂 |
SHA: 2c63082 Reason: push, by nicksteele Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This PR includes a new note detailing two simple examples of "correct"
autocomplete
attributes that should reliably trigger conditional UI across most browsers.Fixes #1982.
Preview | Diff