Skip to content

Commit

Permalink
Merge pull request #39 from wael-sudo2/fix/dependency
Browse files Browse the repository at this point in the history
[FIX] update dependencies and increase dom loading time
  • Loading branch information
wael-sudo2 authored Oct 20, 2024
2 parents a6e8e8a + 0d80d06 commit 76b4552
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 29 deletions.
25 changes: 1 addition & 24 deletions .github/workflows/publish-to-test-pypi.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
publish-to-pypi:
name: >-
Publish Python 🐍 distribution 📦 to PyPI
#if: startsWith(github.ref, 'refs/tags/') # only publish to PyPI on tag pushes
if: startsWith(github.ref, 'refs/tags/')
needs:
- build
runs-on: ubuntu-latest
Expand Down Expand Up @@ -92,26 +92,3 @@ jobs:
'${{ github.ref_name }}' dist/**
--repo '${{ github.repository }}'
publish-to-testpypi:
name: Publish Python 🐍 distribution 📦 to TestPyPI
needs:
- build
runs-on: ubuntu-latest

environment:
name: testpypi
url: https://test.pypi.org/p/facebook-page-info-scraper

permissions:
id-token: write # IMPORTANT: mandatory for trusted publishing

steps:
- name: Download all the dists
uses: actions/download-artifact@v4
with:
name: python-package-distributions
path: dist/
- name: Publish distribution 📦 to TestPyPI
uses: pypa/gh-action-pypi-publish@release/v1
with:
repository-url: https://test.pypi.org/legacy/
4 changes: 2 additions & 2 deletions facebook_page_info_scraper/facebook_page_info_scraper.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ def __private_fetch_page_name(self) -> str | None:

def __private_fetch_basic_info_web_element(self) -> WebElement | None:

WebDriverWait(self.driver, 3).until(
WebDriverWait(self.driver, 5).until(
EC.presence_of_element_located((By.TAG_NAME, 'body'))
)
try:
Expand All @@ -103,7 +103,7 @@ def __private_fetch_basic_info_web_element(self) -> WebElement | None:
# fetch css layout 1 or 2
def __private_fetch_css_layout(self):
self.driver.get(self.__private_clean(self.link))
WebDriverWait(self.driver, 3).until(
WebDriverWait(self.driver, 5).until(
EC.presence_of_element_located((By.TAG_NAME, 'body'))
)
try:
Expand Down
2 changes: 1 addition & 1 deletion facebook_page_info_scraper/version.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "1.1.5"
__version__ = "1.1.6"
4 changes: 2 additions & 2 deletions setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ long_description_content_type = text/x-rst

# add the url to your repository/homepage and version release
url = https://github.com/wael-sudo2/facebook-page-info-scraper
download_url = https://github.com//wael-sudo2/facebook-page-info-scraper/archive/refs/tags/v1.1.5.tar.gz
download_url = https://github.com//wael-sudo2/facebook-page-info-scraper/archive/refs/tags/v1.1.6.tar.gz

# define your license and license file
license = MIT
Expand All @@ -35,5 +35,5 @@ install_requires =
retry~=0.9.2
selenium~=4.8.2
googletrans~=4.0.0rc1

webdriver-manager~=4.0.2
python_requires = >=3.10

0 comments on commit 76b4552

Please sign in to comment.