Extend HDF5 compression options #332
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #332 +/- ##
==========================================
+ Coverage 67.42% 67.50% +0.08%
==========================================
Files 48 48
Lines 7024 7036 +12
Branches 1596 1595 -1
==========================================
+ Hits 4736 4750 +14
+ Misses 1700 1699 -1
+ Partials 588 587 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
waltsims
requested changes
Feb 27, 2024
| Tests the compression option `lzf`, which is not an option for the matlab h5create function, by | ||
| comparing written data to a reference matrix | ||
| """ | ||
| compression_option = 'lzf' |
There was a problem hiding this comment.
I would like to see the test to test all possible compression options.
|
I think this is a great start, but still needs some work before being merged in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #236 by expanding the hdf5 compression options to include
lzfand alsoszipin addition to the standardgzipdefault options (which are integers for the compression level). As such the variable is renamed from compression_level to compression_option.get_h5_literalsis changed to4to match that of the h5py library.h5createcan not write withlzfcompression a test is created in h5io_test