Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress the FileNotFound error when attempting to set the file mode #498

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

faridyagubbayli
Copy link
Collaborator

No description provided.

@waltsims
Copy link
Owner

waltsims commented Nov 5, 2024

Hey Farid,

please ensure tests are passing before I review :)

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.41%. Comparing base (d4b8e3c) to head (c6d2925).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
kwave/executor.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #498      +/-   ##
==========================================
- Coverage   72.43%   72.41%   -0.03%     
==========================================
  Files          46       46              
  Lines        6745     6746       +1     
  Branches     1301     1302       +1     
==========================================
- Hits         4886     4885       -1     
- Misses       1303     1304       +1     
- Partials      556      557       +1     
Flag Coverage Δ
3.10 72.63% <83.33%> (-0.03%) ⬇️
3.11 72.63% <83.33%> (-0.03%) ⬇️
3.12 72.63% <83.33%> (-0.03%) ⬇️
3.9 72.40% <83.33%> (-0.03%) ⬇️
macos-latest 72.41% <83.33%> (-0.03%) ⬇️
ubuntu-latest 72.41% <83.33%> (-0.03%) ⬇️
windows-latest 72.41% <83.33%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@faridyagubbayli
Copy link
Collaborator Author

Hey Walter, good catch! Tests are fixed now.

from kwave.utils.dotdictionary import dotdict


class Executor:
def __init__(self, execution_options, simulation_options):
def __init__(self, execution_options: SimulationExecutionOptions, simulation_options):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could have typed both arguments while you were at it 😅

Copy link
Owner

@waltsims waltsims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waltsims waltsims merged commit 2f5060a into master Nov 12, 2024
44 checks passed
@waltsims waltsims deleted the fix-binary-executable-mode-change branch November 12, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants