-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suppress the FileNotFound error when attempting to set the file mode #498
Conversation
Hey Farid, please ensure tests are passing before I review :) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #498 +/- ##
==========================================
- Coverage 72.43% 72.41% -0.03%
==========================================
Files 46 46
Lines 6745 6746 +1
Branches 1301 1302 +1
==========================================
- Hits 4886 4885 -1
- Misses 1303 1304 +1
- Partials 556 557 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hey Walter, good catch! Tests are fixed now. |
from kwave.utils.dotdictionary import dotdict | ||
|
||
|
||
class Executor: | ||
def __init__(self, execution_options, simulation_options): | ||
def __init__(self, execution_options: SimulationExecutionOptions, simulation_options): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could have typed both arguments while you were at it 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.