Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add full width to document detail fields #7206

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Add full width to document detail fields #7206

merged 2 commits into from
Dec 18, 2024

Conversation

asteriscos
Copy link
Member

@asteriscos asteriscos commented Dec 17, 2024 •
edited
Loading

Description

This pull request adds content to the sample data field data.win.system.message and applies a style so it uses the 100% of the space available.

Issues Resolved

#7204

Evidence

image

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@asteriscos asteriscos self-assigned this Dec 17, 2024
@asteriscos asteriscos linked an issue Dec 17, 2024 that may be closed by this pull request
Some document detail fields don't have the full available width of the column #7204
Closed
@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.3% ( 400 / 883 )
Branches 41.09% ( 157 / 382 )
Functions 43.31% ( 136 / 314 )
Lines 45.48% ( 398 / 875 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 15.46% ( 4617 / 29849 )
Branches 10.14% ( 1953 / 19244 )
Functions 15.38% ( 1111 / 7219 )
Lines 15.69% ( 4508 / 28722 )

yenienserrano
yenienserrano approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢

image

@JuanGarriuz JuanGarriuz self-requested a review December 18, 2024 08:08
JuanGarriuz
JuanGarriuz approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@JuanGarriuz JuanGarriuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test 🟢

image

CR 🟢

LGTM!!!

@yenienserrano
Copy link
Member

Safari 🟢

image

@asteriscos asteriscos merged commit afe3aa4 into 4.10.2 Dec 18, 2024
5 checks passed
@asteriscos asteriscos deleted the bug/7204-add-full-width-to-document-detail-fields branch December 18, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuanGarriuz JuanGarriuz JuanGarriuz approved these changes

@yenienserrano yenienserrano yenienserrano approved these changes

Assignees

@asteriscos asteriscos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some document detail fields don't have the full available width of the column
3 participants
@asteriscos @yenienserrano @JuanGarriuz