Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates transition features with additional keys #2107

Merged
merged 4 commits into from
Nov 6, 2024

Conversation

vwallen
Copy link
Contributor

@vwallen vwallen commented Oct 29, 2024

There's a BCD issue related to the transition-behavior key: mdn/browser-compat-data#24868

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Oct 29, 2024
@@ -2,3 +2,6 @@ name: transition-behavior
description: "The `transition-behavior: allow-discrete` CSS declaration allows transitions for properties whose animation behavior is discrete. Such properties can't be interpolated and swap from their start value to the end value at 50%."
spec: https://drafts.csswg.org/css-transitions-2/#transition-behavior-property
group: transitions
compat_features:
- css.properties.transition-behavior
- css.properties.transition.transition-behavior
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding this currently demotes the feature status from baseline:low to baseline:false.
Is your plan to wait for the BCD bug you mentioned to get resolved before merging this? (So that the baseline status remains the same).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the Blocked flag, and this will be blocked until BCD 5.6.12 is released.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged v5.6.12 today.

@jamesnw jamesnw added the blocked Blocked waiting for something external label Oct 30, 2024
@ddbeck ddbeck removed the blocked Blocked waiting for something external label Nov 4, 2024
Copy link
Collaborator

@jamesnw jamesnw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me- @captainbrosset do you want to take a second look as well?

@jamesnw jamesnw merged commit 0e41e8c into web-platform-dx:main Nov 6, 2024
3 checks passed
@jamesnw jamesnw deleted the key-catchup-transitions branch November 6, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants