Auto-advance date of the next tag
#2428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes softprops/action-gh-release in favor of the `gh` CLI. Fixes web-platform-dx#2068 Closes web-platform-dx#2425
github-actions
bot
added
the
tools and infrastructure
ddbeck
commented
Dec 11, 2024
| @@ -68,20 +68,33 @@ jobs: | |||
| VERSION: ${{ steps.version.outputs.VERSION }} | |||
| TIMESTAMP: ${{ steps.timestamp_and_hash.outputs.TIMESTAMP }} | |||
| SHORT_HASH: ${{ steps.timestamp_and_hash.outputs.SHORT_HASH }} | |||
| - run: npm publish --tag ${{ env.dist_tag }} | |||
| - if: ${{ env.NODE_AUTH_TOKEN }} | |||
There was a problem hiding this comment.
I added this condition to make it easier to test on my fork.
|
@Elchi3 would you be interested in reviewing this? It's primarily a maintainer quality-of-life thing, to stop dismissing the Dependabot upgrade for the GitHub Action. I've tested it on my fork, so I've got fairly high confidence on this one. |
Elchi3
approved these changes
Dec 16, 2024
|
@ddbeck Hello! I am watching releases. |
|
Oh that sounds very annoying. Sorry about that, @szepeviktor—I'll open a PR to revert this until I find another workaround. |
|
Thank you. |
ddbeck
added a commit
to ddbeck/web-features
that referenced
this pull request
Dec 17, 2024
This produces a bunch of needless notifications for release watchers on GitHub. I think there's a way to work around this, but it needs some testing first. This reverts commit 766b40e.
ddbeck
added a commit
to ddbeck/web-features
that referenced
this pull request
Dec 17, 2024
This produces a bunch of needless notifications for release watchers on GitHub. I think there's a way to work around this, but it needs some testing first. This partially reverts commit 766b40e.
|
I've opened #2453. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes softprops/action-gh-release in favor of the
ghCLI.Fixes #2068
Closes #2425