Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix indexeddb name #2443

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Fix indexeddb name #2443

merged 1 commit into from
Dec 13, 2024

Conversation

fiji-flo
Copy link
Contributor

Fix a typo.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Dec 13, 2024
Elchi3
Elchi3 approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm why did CI pass on this? cc @ddbeck

@ddbeck
Copy link
Collaborator

ddbeck commented Dec 13, 2024

hm why did CI pass on this?

Apparently we've been silently ignoring a bunch of errors. I'll have a general fix in follow-up PR.

@ddbeck ddbeck merged commit b73dc0c into web-platform-dx:main Dec 13, 2024
4 checks passed
@ddbeck
Copy link
Collaborator

ddbeck commented Dec 13, 2024

I've opened #2444 to prevent this from happening again in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@captainbrosset captainbrosset captainbrosset approved these changes

@Elchi3 Elchi3 Elchi3 approved these changes

@ddbeck ddbeck ddbeck approved these changes

@argl argl argl approved these changes

Assignees
No one assigned
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fiji-flo @ddbeck @argl @Elchi3 @captainbrosset