stats.ts: count correctly the number keys remaining to be mapped
#2544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
tools and infrastructure
Elchi3
reviewed
Jan 21, 2025
scripts/stats.ts
Outdated
| const doneKeys = Object.values(features).flatMap( | ||
| (f) => f.compat_features ?? [], | ||
| const doneKeys = Array.from( | ||
| new Set(Object.values(features).flatMap((f) => f.compat_features ?? [])), | ||
| ); | ||
| const toDoKeys = []; | ||
| const deprecatedNonStandardKeys = []; |
There was a problem hiding this comment.
Is deprecatedNonStandardKeys used at all still then?
There was a problem hiding this comment.
I removed unused vars with 5331aaf.
ddbeck
added a commit
to ddbeck/web-features
that referenced
this pull request
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we're adding discouraged features, we shouldn't exclude those keys from the count. This correctly measures the total keys remaining (with
currentBurndownSizecontinuing to represent standard, non-deprecated keys).I've also future proofed the count, in the case of allowing a key to appear in multiple features.