Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature improving opencv code #9

Merged
merged 6 commits into from
May 22, 2024
Merged

Conversation

kalwalt
Copy link
Member

@kalwalt kalwalt commented May 21, 2024

First chapter of improvements for webatkit-cv see issue #8
In this PR we implement these features:

  • better import for opencv
  • opencv now is compiled with the MODULARIZE option
  • new class WebARKitCoreCV -> this class is responsable for loading trackables, detecting and tracking of trackers. That is all the code that was in the Worker.ts now is here. The WebARKItCoreCV is instantiated in the Worker.

kalwalt added 3 commits May 21, 2024 00:15
- opencv compiled  as full module
- new WebARKitCoreCV module to instantiate OpenCV -> under development
@kalwalt kalwalt added 🚀 enhancement New feature or request ⌨️ Typescript About Typescript issues and related features 🔬 OpenCV Improvements to OpenCV code and building the source code labels May 21, 2024
@kalwalt kalwalt self-assigned this May 21, 2024
@kalwalt
Copy link
Member Author

kalwalt commented May 22, 2024

i removed the file in the build folder opencv_js.d.ts, it was like this:

declare module 'opencv_js' {
    export function cv(): any;
}

this fixed the warnings in the editor but mke failing the build because is not correct. An example will be from opencv-ts https://github.com/theothergrantdavidson/opencv-ts/blob/master/src/opencv.d.ts but it's not strictly necessary for now. We can add this feature later.

@kalwalt kalwalt merged commit db6f006 into dev May 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔬 OpenCV Improvements to OpenCV code and building the source code 🚀 enhancement New feature or request ⌨️ Typescript About Typescript issues and related features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant