-
-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correct nodeEnv
type in WebpackDevServerOptions
#4378
base: master
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@9romise can you accept CLA? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4378 +/- ##
==========================================
- Coverage 90.18% 83.93% -6.26%
==========================================
Files 22 9 -13
Lines 1702 1413 -289
Branches 491 469 -22
==========================================
- Hits 1535 1186 -349
- Misses 167 227 +60 see 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
OK, I’ve already accepted it. |
@9romise Thanks for your update. I labeled the Pull Request so reviewers will review it again. @anshumanv Please review the new changes. |
@snitin315 Done |
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
No
If relevant, did you update the documentation?
No
Summary
Fix the incorrect type.
Does this PR introduce a breaking change?
No
Other information