Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct nodeEnv type in WebpackDevServerOptions #4378

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

9romise
Copy link

@9romise 9romise commented Jan 23, 2025

What kind of change does this PR introduce?
bugfix

Did you add tests for your changes?
No
If relevant, did you update the documentation?
No
Summary
Fix the incorrect type.

Does this PR introduce a breaking change?
No

Other information

@9romise 9romise requested a review from a team as a code owner January 23, 2025 02:35
Copy link

linux-foundation-easycla bot commented Jan 23, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: 9romise / name: Vida Xie (1c89d81)

Copy link
Member

@anshumanv anshumanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anshumanv
Copy link
Member

@9romise can you accept CLA?

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.93%. Comparing base (31f634a) to head (1c89d81).
Report is 184 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (31f634a) and HEAD (1c89d81). Click for more details.

HEAD has 19 uploads less than BASE
Flag BASE (31f634a) HEAD (1c89d81)
40 21
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4378      +/-   ##
==========================================
- Coverage   90.18%   83.93%   -6.26%     
==========================================
  Files          22        9      -13     
  Lines        1702     1413     -289     
  Branches      491      469      -22     
==========================================
- Hits         1535     1186     -349     
- Misses        167      227      +60     

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62d335e...1c89d81. Read the comment docs.

@9romise
Copy link
Author

9romise commented Jan 23, 2025

@9romise can you accept CLA?

OK, I’ve already accepted it.

@snitin315
Copy link
Member

@9romise Can you once rebase the PR, I've pushed a change to fix the CI on Node v23. #4381

@webpack-bot
Copy link

@9romise Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@anshumanv Please review the new changes.

@9romise
Copy link
Author

9romise commented Jan 24, 2025

@9romise Can you once rebase the PR, I've pushed a change to fix the CI on Node v23. #4381

@snitin315 Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants