Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: stable enforce values validation #905

Merged
merged 6 commits into from
Dec 23, 2024
Merged

feat: stable enforce values validation #905

merged 6 commits into from
Dec 23, 2024

Conversation

wellwelwel
Copy link
Owner

@wellwelwel wellwelwel commented Dec 22, 2024

Now, --ensure or -x flags check for:

  • Invalid flags.
  • Flags with required values, but with no value.
  • Invalid values (--config, --envFile, --concurrency).
  • Flags that don't use values, but have some values in them.
  • Check the configuration files.

Note

Indirectly fixes the issue when importing .cjs or .js files with Bun, which was ignored in Unix systems.


Related:

Copy link

codecov bot commented Dec 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.05%. Comparing base (593e650) to head (d1c2e1d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #905      +/-   ##
==========================================
+ Coverage   98.98%   99.05%   +0.07%     
==========================================
  Files          36       37       +1     
  Lines        1767     1903     +136     
  Branches       11       12       +1     
==========================================
+ Hits         1749     1885     +136     
  Misses          9        9              
  Partials        9        9              
Flag Coverage Δ
linux 98.89% <99.29%> (+0.02%) ⬆️
osx 98.94% <99.29%> (+0.02%) ⬆️
windows 98.94% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wellwelwel wellwelwel changed the title feat(cli): stable enforce values validation feat: stable enforce values validation Dec 23, 2024
@wellwelwel wellwelwel linked an issue Dec 23, 2024 that may be closed by this pull request
4 tasks
@wellwelwel wellwelwel marked this pull request as ready for review December 23, 2024 05:14
@wellwelwel wellwelwel merged commit 3823848 into main Dec 23, 2024
21 checks passed
@wellwelwel wellwelwel deleted the enforce branch December 23, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enforce option stage (Early Development)
1 participant