Fix accidental settings differences between CanvasRenderingContext2D and OffscreenCanvasRenderingContext2D #10904
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a lot of duplicated spec text for
CanvasRenderingContext2D
andOffscreenCanvasRenderingContext2D
, especially related to howCanvasRenderingContext2DSettings
is handled.As with all things that are duplicated, there are accidental divergences. In particular, several members of
CanvasRenderingContext2DSettings
are accidentally ignored in theOffscreenCanvasRenderingContext2D
spec text. Additionally, thegetContextAttributes
method was accidentally not added toOffscreenCanvasRenderingContext2D
when it was added toCanvasRenderingContext2D
.This creates a new mixin interface CanvasSettings. This will unify the accidentally diverged paths, and also prevent this from happening in the future. See details here.
An archeology of where the accidental divergence came from is in this issue. To the extent that original authors are still contact-able, they have confirmed that the divergences were indeed accidental oversights.
/canvas.html ( diff )
/index.html ( diff )