change living parameter to blp in banner shell (#402)

* living>blp living>blp * living>blp * living>blp * fix value * fix value * fix value --------- Co-authored-by: NovemLinguae <[email protected]>
wikimedia-gadgets · Jan 19, 2025 · cba88e4 · cba88e4
1 parent 3541123
commit cba88e4
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/src/modules/core.js b/src/modules/core.js
@@ -1679,17 +1679,17 @@
 			// delete existing biography banner. when accepting, reviewer is forced to choose if it's a biography or not, so we'll add (or not add) our own biography banner later
 			banners = banners.filter( ( value ) => !value.match( /^{{WikiProject Biography/i ) );
 
-			// add biography banner to array. and add |living= and |listas= to banner shell
+			// add biography banner to array. and add |blp= and |listas= to banner shell
 			let bannerShellExtraParams = '';
 			if ( isBiography ) {
 				banners.push(
 					'{{WikiProject Biography}}'
 				);
 
 				if ( lifeStatus === 'living' ) {
-					bannerShellExtraParams += ' |living=yes';
+					bannerShellExtraParams += ' |blp=yes';
 				} else if ( lifeStatus === 'dead' ) {
-					bannerShellExtraParams += ' |living=no';
+					bannerShellExtraParams += ' |blp=no';
 				}
 
 				if ( subjectName ) {

diff --git a/tests/test-core.js b/tests/test-core.js
@@ -281,7 +281,7 @@ I have a question. Can you help answer it? –[[User:Novem Linguae|<span style="
 		const subjectName = 'Lazarut, Raluca';
 		const output = AFCH.addTalkPageBanners( wikicode, newAssessment, revId, isBiography, newWikiProjects, lifeStatus, subjectName );
 		expect( output ).toBe(
-`{{WikiProject banner shell |living=yes |listas=Lazarut, Raluca |1=
+`{{WikiProject banner shell |blp=yes |listas=Lazarut, Raluca |1=
 {{subst:WPAFC/article |oldid=592507}}
 {{WikiProject Film}}
 {{WikiProject Women}}
@@ -326,7 +326,7 @@ I have a question. Can you help answer it? –[[User:Novem Linguae|<span style="
 		const subjectName = 'Jones, Bob';
 		const output = AFCH.addTalkPageBanners( wikicode, newAssessment, revId, isBiography, newWikiProjects, lifeStatus, subjectName );
 		expect( output ).toBe(
-`{{WikiProject banner shell |class=B |living=yes |listas=Jones, Bob |1=
+`{{WikiProject banner shell |class=B |blp=yes |listas=Jones, Bob |1=
 {{subst:WPAFC/article |oldid=592496}}
 {{WikiProject Biography}}
 {{WikiProject Africa}}
@@ -345,7 +345,7 @@ I have a question. Can you help answer it? –[[User:Novem Linguae|<span style="
 		const subjectName = '';
 		const output = AFCH.addTalkPageBanners( wikicode, newAssessment, revId, isBiography, newWikiProjects, lifeStatus, subjectName );
 		expect( output ).toBe(
-`{{WikiProject banner shell |living=no |1=
+`{{WikiProject banner shell |blp=no |1=
 {{subst:WPAFC/article |oldid=592496}}
 {{WikiProject Biography}}
 }}`
@@ -354,7 +354,7 @@ I have a question. Can you help answer it? –[[User:Novem Linguae|<span style="
 
 	it.skip( 'talk page has {{wikiproject biography}}, and user selects that it\'s not a biography, so should remove {{wikiproject biography}}', () => {
 		const wikicode =
-`{{wikiproject biography|living=yes|class=B|listas=Jones, Bob}}
+`{{wikiproject biography|blp=yes|class=B|listas=Jones, Bob}}
 {{WikiProject Somalia}}`;
 		const newAssessment = '';
 		const revId = 592496;