Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix notebook precommit #378

Merged
merged 4 commits into from
Dec 30, 2024
Merged

Fix notebook precommit #378

merged 4 commits into from
Dec 30, 2024

Conversation

atmorling
Copy link
Contributor

Closes #377

  • Removes nbqa pre-commit hook
  • Updates the Jupyter Notebooks with line length fixes (turns out the nbqa hook wasn't enforcing this properly)
  • Also includes a ruff pass over the code which should have been done in Pre commit update + dependabot CI fix #372 - hence the massive diff.

@atmorling atmorling requested a review from Yun-Wu December 30, 2024 09:29
@atmorling atmorling force-pushed the am/notebook_precommit branch from 76308fc to a78d190 Compare December 30, 2024 09:53
Yun-Wu
Yun-Wu approved these changes Dec 30, 2024
View reviewed changes
Copy link
Contributor

@Yun-Wu Yun-Wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you very much for doing it!

@atmorling atmorling merged commit 88769cd into master Dec 30, 2024
5 checks passed
@atmorling atmorling deleted the am/notebook_precommit branch December 30, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yun-Wu Yun-Wu Yun-Wu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nbqa conflicts with ruff in pre-commit
2 participants
@atmorling @Yun-Wu