Various changes to StructureTemplates, 1.20.3 branch. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in keys Allow for arrays of strings in the keys of a structure template. All the elements are parsed the same as they previously were, this just allows for defining a list of possible blocks. Also clean up code a decent amount to make it a tad more maintainable. Signed-off-by: solonovamax <[email protected]>
- Implement Iterable<Pair<BlockPos, BlockStatePredicate>> for StructureTemplate - Convert all fields to getters and introduce getters for more fields Signed-off-by: solonovamax <[email protected]>
Add the ability to pickblock block that are in a structure preview Note: the pickblock will *only* work on the currently previewed block, and not any compatible block. eg. if in survival and the position you pickblock allows for either stone or dirt if the preview is showing stone, and you have dirt in your inventory and pickblock it, then it will not select the dirt. Signed-off-by: solonovamax <[email protected]>
Signed-off-by: solonovamax <[email protected]>
solonovamax
changed the title
Signed-off-by: solonovamax <[email protected]>
|
Closing. See: #13 (review) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed several things to do with
StructureTemplates: