Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: metadata string encoding #420

Merged
merged 5 commits into from
Jan 27, 2025
Merged

fix: metadata string encoding #420

merged 5 commits into from
Jan 27, 2025
+43 −38

Conversation

giladgd
Copy link
Contributor

@giladgd giladgd commented Jan 26, 2025 •
edited
Loading

Description of change

  • fix: metadata string encoding
  • fix: Vulkan parallel decoding
  • fix: try auth token on 401 response
  • docs: typos

Fixes #418

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply eslint formatting
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits and pull request title follow conventions explained in pull request guidelines (PRs that do not follow this convention will not be merged)

@giladgd giladgd requested a review from ido-pluto January 26, 2025 01:12
@giladgd giladgd self-assigned this Jan 26, 2025
@giladgd giladgd merged commit 314d7e8 into master Jan 27, 2025
19 checks passed
@giladgd giladgd deleted the gilad/fixGgufStringEncoding branch January 27, 2025 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ido-pluto ido-pluto Awaiting requested review from ido-pluto

Assignees

@giladgd giladgd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Naive parsing lead to incorrect UTF-8 character recognition in GGUF metadata
1 participant
@giladgd