Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix setRoot animations on iOS #7071

Merged
merged 1 commit into from
Apr 4, 2021
Merged

Fix setRoot animations on iOS #7071

merged 1 commit into from
Apr 4, 2021

Conversation

yogevbd
Copy link
Collaborator

@yogevbd yogevbd commented Apr 4, 2021 •
edited
Loading

Processing setRoot animations options for enter and exit animations on Android broke the iOS implementation.

Closes #7068, #7066

@yogevbd yogevbd requested a review from swabbass April 4, 2021 09:03
@yogevbd yogevbd changed the title Fix setRoot waitForRender on iOS Fix setRoot animations on iOS Apr 4, 2021
@swabbass swabbass merged commit 8e5cda2 into master Apr 4, 2021
@guyca guyca deleted the fixSetRootIOS branch April 4, 2021 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swabbass swabbass swabbass approved these changes

Assignees
No one assigned
Labels
platform: iOS type: accepted/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[7.12.0] waitForRender doesn't work as expected on iOS
2 participants
@yogevbd @swabbass