resolve memory leak on error

wolfSSL · Jan 9, 2025 · bdc1b19 · bdc1b19
1 parent 9d6643c
commit bdc1b19
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/tls13.c b/src/tls13.c
@@ -6909,6 +6909,12 @@ int DoTls13ClientHello(WOLFSSL* ssl, const byte* input, word32* inOutIdx,
     if (args->clSuites == NULL) {
         ERROR_OUT(MEMORY_E, exit_dch);
     }
+#ifdef OPENSSL_EXTRA
+    /* hang on to client suites found and free the struct when WOLFSSL object
+     * is free'd */
+    XFREE(ssl->clSuites, ssl->heap, DYNAMIC_TYPE_SUITES);
+    ssl->clSuites = args->clSuites;
+#endif
 
     /* Cipher suites */
     if ((args->idx - args->begin) + OPAQUE16_LEN > helloSz)
@@ -7081,7 +7087,6 @@ int DoTls13ClientHello(WOLFSSL* ssl, const byte* input, word32* inOutIdx,
     case TLS_ASYNC_DO:
     {
 #ifdef OPENSSL_EXTRA
-    ssl->clSuites = args->clSuites;
     if ((ret = CertSetupCbWrapper(ssl)) != 0)
         goto exit_dch;
 #endif