ML-KEM compatibility #7807
Merged
ML-KEM compatibility #7807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Thank you @Frauschi ! Okay to test. Contributor agreement on file. |
|
Retest this please |
As the WolfSSL implementation of the PQC KEM algorithm kyber also supports the ML-KEM draft version (enabled by `WOLFSSL_ML_KEM`), we have to update the groups code point to be compatible with other TLS implementations (e.g. OQS provider). Also updated the reference to the source of the values to the current OQS Github. Signed-off-by: Tobias Frauenschläger <[email protected]>
dgarske
approved these changes
Aug 5, 2024
|
Yep, I double checked against the oqs provider docs. It matches. |
anhu
approved these changes
Aug 14, 2024
This was referenced Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
As the WolfSSL implementation of the PQC KEM algorithm Kyber also supports the ML-KEM draft version (enabled by
WOLFSSL_ML_KEM), we have to update the groups code points to be compatible with other TLS implementations (e.g. OQS provider).Also updated the reference to the source of the values to the current OQS GitHub (see here).
Testing has been done using the current master of oqs-provider.