Skip to content

Commit

Permalink
workflows/eval: run when base branch changed
Browse files Browse the repository at this point in the history
When the base branch changes, we need to run full eval again, because
the changed output paths depend on the base branch.
  • Loading branch information
wolfgangwalther committed Jan 11, 2025
1 parent 42dd398 commit 941a690
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 1 deletion.
7 changes: 7 additions & 0 deletions .github/workflows/edited-base.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,13 @@ jobs:
name: Codeowners v2
uses: ./.github/workflows/codeowners-v2.yml

eval:
name: Eval
uses: ./.github/workflows/eval.yml
permissions:
pull-requests: write
statuses: write

labels:
name: Label PR
uses: ./.github/workflows/labels.yml
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/edited.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ jobs:
name: Base
if: github.event.changes.base.ref.from && github.event.changes.base.ref.from != github.event.pull_request.base.ref
uses: ./.github/workflows/edited-base.yml
# Currently needed downstream for labels.yml
# Currently needed downstream for eval.yml and labels.yml
permissions:
contents: read
pull-requests: write
statuses: write
1 change: 1 addition & 0 deletions .github/workflows/eval.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ name: Eval

on:
pull_request_target:
workflow_call:
push:
# Keep this synced with ci/request-reviews/dev-branches.txt
branches:
Expand Down

0 comments on commit 941a690

Please sign in to comment.