test stuff edited 5 #631
Closed
test stuff edited 5 #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfgangwalther
force-pushed
the
master
branch
from
0c0c9e4 to
52456be
Compare
wolfgangwalther
force-pushed
the
ci-test
branch
from
c07de5a to
f8f3fbc
Compare
wolfgangwalther
force-pushed
the
master
branch
4 times, most recently
from
0dcc6a6 to
65aa212
Compare
This seems to be unused. It can be triggered manually, but is this really done? Is this superseded by the new eval checks or should we instead run this regularly?
All other workflows do - and most importantly actionlint only runs on .yml files!
mergedSha is available from needs.get-merge-commit, not needs.attrs. Actionlint rightfully complains about that. The code still works as expected because nixpkgs/ is checked out at mergedSha, so the diff will be between mergedSha and baseSha.
Same top-level ordering of keys / empty lines and same indentation for yaml lists. One blank line between each step. Makes it easier to read and compare the workflows.
The eval-aliases job is independent of attrs already and the tag job doesn't need it to checkout the base branch.
No need for that limitation, which only artifically limits test-ability of CI in forks. Some other workflows like backports, cherry-pick checks and periodic merges are very specific to the release branches and don't need to be run in forks.
It seems odd to exclude PRs against release branches for those checks - especially when not excluding PRs against staging-** variants at the same time.
Less repetition, more consistency.
We currently use two different "base" commits, but the same name. One of them is the commit in which context the pull_request_target runs. The other is the parent of the merge commit. Those are **not** necessarily the same - see README introduced in the next commit for details. Renaming one of them for clarity. Since the pull_request_target related base commit is also called like that in GitHub Actions terminology, we rename the other. The best I could come up with is "target".
This introduces some basic concepts used in these workflows and a common terminology. At the same time we remove some of the comments from various workflow files, because they are assumed to be "general knowledge" through the README.
wolfgangwalther
force-pushed
the
master
branch
from
65aa212 to
2682534
Compare
wolfgangwalther
force-pushed
the
ci-test
branch
2 times, most recently
from
d85d31b to
1254767
Compare
wolfgangwalther
force-pushed
the
ci-test
branch
from
1254767 to
cdcf8ff
Compare
wolfgangwalther
force-pushed
the
master
branch
from
e0bf945 to
fd464ec
Compare
wolfgangwalther
force-pushed
the
ci-test
branch
from
cdcf8ff to
819e361
Compare
wolfgangwalther
force-pushed
the
master
branch
from
fd464ec to
c98c507
Compare
wolfgangwalther
force-pushed
the
ci-test
branch
from
819e361 to
c20bd08
Compare
wolfgangwalther
force-pushed
the
master
branch
from
c98c507 to
5c5cd64
Compare
wolfgangwalther
force-pushed
the
ci-test
branch
from
c20bd08 to
c48dadd
Compare
wolfgangwalther
force-pushed
the
master
branch
from
5c5cd64 to
74aa9e6
Compare
wolfgangwalther
force-pushed
the
ci-test
branch
from
c48dadd to
6e048eb
Compare
wolfgangwalther
force-pushed
the
master
branch
from
74aa9e6 to
6c24f43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.