[Woo POS] Switch to dynamic card reader hint instead of hardcoded "Remove card" prompt #13283
+8
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #13264
Description
This PR slightly changes the texts shown in the payment flow in POS.
The hardcoded "Remove card" hint has now been deleted in this PR in favor of relying on dynamic hints that come from Terminal SDK. This improves the experience in case the reader asks to insert card inside the reader or to enter PIN – the hardcoded "Remove card" hint turned out to be misleading when testing a UK-based store.
Steps to reproduce
WooPosIsEnabled
or runningWooPosActivity
directly in AS).02
to emulateoffline_pin_required
terminal error.Testing information
POS should not show hardcoded hints for payment states, rather the ones that come from payment state's
readerHint
property.The tests that have been performed
I tested the card payment flow in POS for the UK-based store, for a total of 3.02 GBP. I verified that in case reader asks to insert the card, the "Please wait..." message is shown instead of "Remove card".
Samsung Tab S9, Android 14
Images/gif
—
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: