Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Woo POS] Switch to dynamic card reader hint instead of hardcoded "Remove card" prompt #13283

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from

Conversation

samiuelson
Copy link
Collaborator

@samiuelson samiuelson commented Jan 10, 2025

Closes: #13264

Description

This PR slightly changes the texts shown in the payment flow in POS.

The hardcoded "Remove card" hint has now been deleted in this PR in favor of relying on dynamic hints that come from Terminal SDK. This improves the experience in case the reader asks to insert card inside the reader or to enter PIN – the hardcoded "Remove card" hint turned out to be misleading when testing a UK-based store.

Steps to reproduce

  1. Switch to UK-based store
  2. Open POS (either by overriding conditions in WooPosIsEnabled or running WooPosActivity directly in AS)
  3. Add to cart a product with price having decimals equal to .02 to emulate offline_pin_required terminal error.
  4. Notice that POS shows text "Remove card", while reader asks to insert the card to the reader (confusing!)

Testing information

POS should not show hardcoded hints for payment states, rather the ones that come from payment state's readerHint property.

The tests that have been performed

I tested the card payment flow in POS for the UK-based store, for a total of 3.02 GBP. I verified that in case reader asks to insert the card, the "Please wait..." message is shown instead of "Remove card".

Samsung Tab S9, Android 14

Images/gif

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

…ed-with-please-wait-in-case-of-002-gbp-error
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 10, 2025

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commitdae828e
Direct Downloadwoocommerce-wear-prototype-build-pr13283-dae828e.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 10, 2025

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commitdae828e
Direct Downloadwoocommerce-prototype-build-pr13283-dae828e.apk

…ed-with-please-wait-in-case-of-002-gbp-error
@samiuelson samiuelson marked this pull request as ready for review January 10, 2025 16:32
@samiuelson samiuelson requested a review from kidinov January 10, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[POS] "Remove card" text should be replaced with "Please wait..." in case of 0.02 GBP error
2 participants