Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/85: unblock UI and show generic error when buyer verification fails #265

Merged
merged 8 commits into from
Jan 17, 2025

Conversation

Sidsector9
Copy link
Member

All Submissions:

  • Does your code follow the WooCommerce Sniffs variant of WordPress coding standards?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Will this change require new documentation or changes to existing documentation?

Changes proposed in this Pull Request:

This PR unblocks the UI and shows a generic error on the Checkout page when the buyer verification fails.

Closes #85

Steps to test the changes in this Pull Request:

  1. On trunk, perform a Checkout with the card 4310 0000 0020 1019.
  2. Cancel the verification Challenge once it shows up.
  3. Observe the Checkout page being blocked.
  4. Switch to the fix branch and repeat.
  5. Observe the Checkout page is unblocked and the page shows a generic error.

Changelog entry

Fix - Unblock the Checkout page UI, and show a generic error when buyer verification fails.

@dkotter dkotter added the needs: UAT The Issue/PR needs to go through UAT label Jan 10, 2025
@dkotter
Copy link
Contributor

dkotter commented Jan 10, 2025

This can go to UAT once QA passes

@qasumitbagthariya
Copy link
Contributor

QA Update ✅


I have verified this PR in the fix/85 branch which has been fixed and is functioning as intended.

Testing Environment

  • WordPress: 6.7.1
  • Theme: Twenty Twenty-Four 1.3
  • WooCommerce - 9.5.1
  • PHP: 8.0.30
  • Web Server: Nginx 1.20.2
  • Browser: Chrome
  • OS: macOS Ventura 15.2
  • Branch: fix/85
Screen.Recording.2025-01-13.at.7.41.37.PM.mov

Steps to Test- As mentioned in the PR description.
Test Results - It is working as expected.
Functional Demo / Screencast -
Special Notes - Ready for UAT
Testing Document status:
Cases related to this Issue/PR are added to the Critical Flow Wiki pages:

  • Yes
  • Not Required/Applicable for this PR

@jeffpaul jeffpaul added this to the Future Release milestone Jan 13, 2025
@vikrampm1 vikrampm1 modified the milestones: Future Release, 4.8.5 Jan 17, 2025
@vikrampm1 vikrampm1 merged commit c8d62f7 into trunk Jan 17, 2025
8 of 9 checks passed
@vikrampm1 vikrampm1 deleted the fix/85 branch January 17, 2025 14:25
@vikrampm1 vikrampm1 mentioned this pull request Jan 17, 2025
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VerifyBuyerError not caught or handled in validation
5 participants