-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/85: unblock UI and show generic error when buyer verification fails #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
status: e2e tests passing
and removed
status: e2e tests passing
labels
Jan 10, 2025
dkotter
approved these changes
Jan 10, 2025
This can go to UAT once QA passes |
github-actions
bot
added
status: e2e tests passing
status: e2e tests failing
and removed
status: e2e tests passing
labels
Jan 12, 2025
QA Update ✅I have verified this PR in the Testing Environment
Screen.Recording.2025-01-13.at.7.41.37.PM.movSteps to Test- As mentioned in the PR description.
|
qasumitbagthariya
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
This PR unblocks the UI and shows a generic error on the Checkout page when the buyer verification fails.
Closes #85
Steps to test the changes in this Pull Request:
trunk
, perform a Checkout with the card4310 0000 0020 1019
.Changelog entry