refactor(core): remove get component bridge officially (#863)

worktile · Apr 30, 2024 · 61d00e0 · 61d00e0
1 parent a1e2b94
commit 61d00e0
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 12 deletions.
diff --git a/.changeset/rare-onions-collect.md b/.changeset/rare-onions-collect.md
@@ -0,0 +1,9 @@
+---
+'@plait/core': minor
+---
+
+remove get component bridge officially 🎉🎉🎉
+
+- remove ELEMENT_TO_COMPONENT
+
+- remove getComponent method
diff --git a/packages/core/src/core/element/plugin-element.ts b/packages/core/src/core/element/plugin-element.ts
@@ -39,9 +39,6 @@ export abstract class PlaitPluginElementComponent<
         }
         const previousContext = this._context;
         this._context = value;
-        if (this.element) {
-            ELEMENT_TO_COMPONENT.set(this.element, this);
-        }
         if (this.initialized) {
             const elementG = this.getElementG();
             const containerG = this.getContainerG();
@@ -153,9 +150,6 @@ export abstract class PlaitPluginElementComponent<
     }
 
     ngOnDestroy(): void {
-        if (ELEMENT_TO_COMPONENT.get(this.element) === this) {
-            ELEMENT_TO_COMPONENT.delete(this.element);
-        }
         if (NODE_TO_G.get(this.element) === this._g) {
             NODE_TO_G.delete(this.element);
         }
@@ -169,5 +163,3 @@ export abstract class PlaitPluginElementComponent<
         this.getContainerG().remove();
     }
 }
-
-export const ELEMENT_TO_COMPONENT = new WeakMap<PlaitElement, PlaitPluginElementComponent>();
diff --git a/packages/core/src/interfaces/element.ts b/packages/core/src/interfaces/element.ts
@@ -1,4 +1,3 @@
-import { ELEMENT_TO_COMPONENT, PlaitPluginElementComponent } from '../core/element/plugin-element';
 import { ELEMENT_TO_REF, NODE_TO_CONTAINER_G, NODE_TO_G, NODE_TO_PARENT } from '../utils';
 import { PlaitBoard } from './board';
 import { Point } from './point';
@@ -22,9 +21,6 @@ export const PlaitElement = {
             return false;
         }
     },
-    getComponent(value: PlaitElement) {
-        return ELEMENT_TO_COMPONENT.get(value) as PlaitPluginElementComponent;
-    },
     getElementRef<T extends PlaitElementRef = PlaitElementRef>(value: PlaitElement) {
         return ELEMENT_TO_REF.get(value) as T;
     },