Remove "Review transaction" view #3164
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for wormhole-connect pending review.Visit the deploys page to approve it
|
✅ Deploy Preview for wormhole-connect-mainnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
emreboga
commented
Jan 9, 2025
| @@ -7,7 +7,6 @@ type Props = { | |||
| destChain: Chain | undefined; | |||
| destToken: string; | |||
| route?: string; | |||
| valid: boolean; | |||
There was a problem hiding this comment.
If gas top-up is not available for the route, we don't show it in the first place; hence this property is no longer needed.
emreboga
commented
Jan 9, 2025
There was a problem hiding this comment.
Please note that git thinks this was a move from views/v2/Bridge/ReviewTransaction/index.ts to hooks/useConfirmTransaction.ts because the most of the lines in the first one was moved over to the second one. However we actually just moved the send function to new hook and deleted views/v2/Bridge/ReviewTransaction/index.ts.
emreboga
force-pushed
the
emre/remove-review-tx-view-4
branch
from
43e6091 to
525af70
Compare
Signed-off-by: Emre Bogazliyanlioglu <[email protected]>
Signed-off-by: Emre Bogazliyanlioglu <[email protected]>
Signed-off-by: Emre Bogazliyanlioglu <[email protected]>
Signed-off-by: Emre Bogazliyanlioglu <[email protected]>
Signed-off-by: Emre Bogazliyanlioglu <[email protected]>
emreboga
force-pushed
the
emre/remove-review-tx-view-4
branch
from
525af70 to
5ef14cf
Compare
Signed-off-by: Emre Bogazliyanlioglu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will remove the "Review Transaction" view/step and allow user to confirm a transaction from the main view. One important change here is moving the gas slider inside the route card for those that has gas top-up enabled.