Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site health improvements - january report #199

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

0xlukem
Copy link
Contributor

@0xlukem 0xlukem commented Jan 15, 2025

Description

Based on the January SEMrush report, I updated the Wormhole-Docs site health by addressing several broken links and some missing ones.

Checklist

  • Required - I have added a label to this PR 🏷️
  • Required - I have run my changes through Grammarly
  • If pages have been moved, I have created redirects in the wormhole-mkdocs repo

@0xlukem 0xlukem force-pushed the 0xlukem/semrush-health-check branch from fa1b2f3 to 1d4df51 Compare January 15, 2025 15:53
@eshaben eshaben added A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) B0 - Needs Review Pull request is ready for review C1 - Medium Medium priority task labels Jan 17, 2025
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple minor things but looks good!

eshaben
eshaben previously approved these changes Jan 21, 2025
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eshaben
Copy link
Collaborator

eshaben commented Jan 21, 2025

@0xlukem there's a merge conflict on one of the automated pages. So what I would do is just accept one or the other, but then you'll need to run the script again to make sure you've pulled in all of the latest updates

@0xlukem 0xlukem requested a review from eshaben January 21, 2025 23:54
eshaben
eshaben previously approved these changes Jan 22, 2025
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eshaben eshaben added B1 - Ready to Merge Pull request is ready to be merged and removed B0 - Needs Review Pull request is ready for review labels Jan 22, 2025
@eshaben
Copy link
Collaborator

eshaben commented Jan 22, 2025

@0xlukem actually just saw this PR: #210

What happened was that Martin updated #210 based on the changes made in this mkdocs PR, which hasn't been merged yet: papermoonio/wormhole-mkdocs#129

So your PR will need to be updated again with the new chain config added in that PR. Sorry about the back and forth on this!

@eshaben eshaben removed the B1 - Ready to Merge Pull request is ready to be merged label Jan 22, 2025
@eshaben
Copy link
Collaborator

eshaben commented Jan 24, 2025

@0xlukem just merged the script changes into dev. So you can run the scripts again from that branch to make the updates needed for this PR now 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) C1 - Medium Medium priority task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants