-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update plugin php min version to 7.4 #2035
Conversation
|
📦 Next.js Bundle Analysis for @faustwp/getting-started-exampleThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
* | ||
* @return string Minimum version required. | ||
*/ | ||
function faustwp_minimum_php_requirement() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would love to suggest to have only one place for specifying the min php version - in plugin's header. That will allow us to edit min php version only once, and move the functionality into a standalone class in future. We can use get_plugins
or get_file_data
or get_plugins_data
... But I am not sure how relevant it is now, maybe a good thing to keep in mind for future
Tasks
Description
Faustwp: Set php min version to v7.4
Related Issue(s):
#2022
Testing
Screenshots
Documentation Changes
Dependant PRs