fix(Context): Fix deleting cache in context and drop tags usage by de…

…fault BREAKING CHANGE: Drop default tag for context cache - Laravel offical recommendation is not to use tags with redis
wrk-flow · Jul 29, 2024 · d9e2469 · d9e2469
1 parent c2f8bc0
commit d9e2469
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/src/Context/Services/ContextService.php b/src/Context/Services/ContextService.php
@@ -19,8 +19,6 @@
 
 class ContextService implements ContextServiceContract
 {
-    protected const TAG = 'context';
-
     public function __construct(
         private readonly CacheMeServiceContract $cacheMeManager,
         private readonly ImplementsService $implementsService
@@ -31,7 +29,11 @@ public function delete(AbstractContext $context): void
     {
         $fullCacheKey = $this->getCacheKey($context);
 
-        $this->cacheMeManager->delete(key: $fullCacheKey, strategy: $this->cacheStrategy($context));
+        $this->cacheMeManager->delete(
+            key: $fullCacheKey,
+            tags: $this->getTags($context),
+            strategy: $this->cacheStrategy($context)
+        );
     }
 
     /**
@@ -99,7 +101,7 @@ protected function cacheStrategy(AbstractContext $context): CacheMeStrategy
 
     protected function getTags(AbstractContext $context): array
     {
-        $tags = [self::TAG];
+        $tags = [];
 
         if ($this->implementsService->check($context, UseCacheWithTags::class) === false) {
             return $tags;

diff --git a/tests/Feature/Context/Services/ContextServiceTest.php b/tests/Feature/Context/Services/ContextServiceTest.php
@@ -76,7 +76,7 @@ public function assert(
             cacheMeManager: new CacheMeServiceContractAssert(get: [
                 new CacheMeServiceContractGetExpectation(
                     key: $expectedCacheKey,
-                    tags: ['context'],
+                    tags: [],
                     minutes: 3600,
                     strategy: CacheMeStrategy::Memory,
                     callGetValueHook: $callHook