Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency Update - PEP 594 - Installs standard-imghdr dependency #117

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NicolasFlandrois
Copy link

As of PEP-594, for Python 3.13 the imghdr module has been removed from standard library (deprecated since Python 3.11). cf: https://peps.python.org/pep-0594/#imghdr

EPY program requested this dependency on fresh install on Python 3.13 . This patch install the package by default, regardless of Python version. If already installed in a lower Python version, it will update the package. If the python is >3.13.0, it will install the package.

As of PEP-594, for Python 3.13 the `imghdr` module has been removed from standard library (deprecated since Python 3.11).
cf: https://peps.python.org/pep-0594/#imghdr

EPY program requested this dependency on fresh install on Python 3.13 .
This patch install the package by default, regardless of Python version. If already installed in a lower Python version, it will update the package. If the python is >3.13.0, it will install the package.
@NicolasFlandrois
Copy link
Author

Hello Benawi Adha "Wustho",

Thank you for considering this Pull Request. It will improve users' experience when installing Python 3.13 and higher.
The newer Python version deprecates this standard library, and the pull request simply installs what used to be a standard library.

@holytrousers
Copy link

Thank you @NicolasFlandrois for this PR.
epy stopped working after updating python and now it works back.

@NicolasFlandrois
Copy link
Author

NicolasFlandrois commented Dec 23, 2024

Thank you @NicolasFlandrois for this PR.
epy stopped working after updating python and now it works back.

I hope the PR will go through, to ease future installations and less technically savy people.

Glad it could help someone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants