Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add zoom to scatterplot #103

Open
wants to merge 1 commit into
base: alpha
Choose a base branch
from
Open

add zoom to scatterplot #103

wants to merge 1 commit into from

Conversation

Kvaz1r
Copy link
Contributor

@Kvaz1r Kvaz1r commented Jan 17, 2019

For #84 .

There isn't anything really new - all changes just copy-pasted code from wxmath2dplot.

@Anton-V-K
Copy link

Any plans to merge these changes? :)

@helha54
Copy link

helha54 commented Mar 7, 2021

I tried the code-changes (from thefile-changes) but it failed with shredptr.h(85): assert "m_ref!=_null" failed in operator ->0

I try to minimize the xy-dots to smaller points from the size like ball's (as it is now)

@Kvaz1r
Copy link
Contributor Author

Kvaz1r commented Mar 7, 2021

I tried the code-changes (from thefile-changes) but it failed with shredptr.h(85): assert "m_ref!=_null" failed in operator ->0

I try to minimize the xy-dots to smaller points from the size like ball's (as it is now)

  1. Code in this PR doesn't contains anything that can lead to break not null assert. I think that reason the same as in StackedColumnChart can't take more than 3 datasets #165. 3 datasets is current restriction for all charts.

  2. As for now radius for scatter always equals 5, but you can change the value here and re-build the library.

@helha54
Copy link

helha54 commented Mar 7, 2021

I found the reason. There are two lines missing in, when re-insert them everything is ok. That is one include-line
#include "wxchartstheme.h"

wxScatterPlot::wxScatterPlot(const wxScatterPlotData &data,
const wxSize &size)
:m_options(wxChartsDefaultTheme->GetScatterPlotOptions()),

where the last line ' : m_opions' is missing

After inserting them everything is ok.

@helha54
Copy link

helha54 commented Mar 7, 2021

I reduced the point-size to 1 and that is what i needed.

I run scatterplot with 5 datasets, so it seems to work with 5 datasets least. ( just as information)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants