fix: 修复 bar3d 图形在线条连接点处有突出，以及在图形堆叠时存在重复边的问题 #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
由于加入了 line join 和 line cap 的设置，线条可以调整线帽和线条连接样式，按照原先的绘制顺序在左上角会有突出部分。并且在 topFlag 为 false 时仍然多绘制了顶部的其中一条边。 |
|
调整后图形正常，并且堆叠时无重复边。 |
yixy-only
force-pushed
the
refactor_bar3d
branch
from
42eb6b9 to
0f31222
Compare
yixy-only
changed the title
wysaid
reviewed
Oct 4, 2024
src/egegapi.cpp
Outdated
| drawpoly(7, pt, pimg); | ||
| } | ||
| /* 正面右上边界的3个顶点 */ | ||
| POINT sideVertexes[3] = {{left, top}, {right, top}, {right, bottom}}; |
There was a problem hiding this comment.
这个变量似乎只在 if(topFlag) 进去的时候才需要？ else 里面可以直接使用 left、top等， 你看看要不要优化下？ 不过不改也没事...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.