Add channelResponseCallback to onJoinChannel action. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now getPhoenixChannel method takes "channelResponseEvent" and "channelErrorResponseEvent" string params and dispatch corresponding actions as a callback.
RamanQDO
force-pushed
the
on-join-actions
branch
from
55e6889 to
1e59e6a
Compare
kuzaxak
requested changes
Jan 7, 2022
Comment on lines
+204
to
+206
| dispatch( | ||
| endPhoenixChannelProgress({ dispatch, channelTopic, loadingStatusKey: channelTopic }) | ||
| ); |
There was a problem hiding this comment.
Please do not use fixed for formatting commits. Formatting is a separated logic that should be added as a separate commit.
If channel isn't created yet we will never bind an events to it.
Regarding [guideline][1] we should use `payload` as a data key inside actions. `Should always put their data into a payload field` [1]: https://redux.js.org/style-guide/style-guide#write-actions-using-the-flux-standard-action-convention
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to existing implementation we only get default JOIN_FAILED response, which is very complex to differentiate from other onChannelJoin events (we could have plenty of them in the same time)