This repository has been archived by the owner on Dec 10, 2024. It is now read-only.
Add 15 Missing GitLab Settings #1985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These settings were found by perusing documentation and code in response to gitlab-org/terraform-provider-gitlab#6332.
svanharmelen
approved these changes
Aug 13, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have discovered a bit under 40 settings that have been added to GitLab's API but are currently missing in this project. In this PR I'm taking the first stab at correcting this by adding in 15 missing settings. I can have this single PR include them all, but I was worried about overwhelming you with a really big PR.
These settings were found by perusing documentation and code in response to gitlab-org/terraform-provider-gitlab#6332.
I'm not sure how you would like to go about testing these. If you'd like, I can manually test all of them myself using a GDK installed GitLab installation, but I didn't know if you'd rather test them out yourself. Let me know in either regard and I'll be happy to do whatever you'd like.