fix(ISOSR): type accepts 'nfs_iso' not 'nfs' as the docs claim #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://github.com/xapi-project/sm/blob/master/drivers/ISOSR.py#L318-L326 Valid values for type are `cifs` or `nfs_iso`. Signed-off-by: Edwin Török <[email protected]>
edwintorok
force-pushed
the
edwintorok-patch-1
branch
from
7121910 to
f2b2a2f
Compare
MarkSymsCtx
previously approved these changes
Dec 8, 2023
Signed-off-by: Mark Syms <[email protected]>
rdn32
approved these changes
Dec 8, 2023
KevinLCtx
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/xapi-project/sm/blob/master/drivers/ISOSR.py#L318-L326
Valid values for type are
cifsornfs_iso. That is not very consistent but the built-in docs should reflect reality, the code can be extended later to support more consistent naming.