CP-52852: add handler for xmlrpc ProtocolError #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinLCtx
previously approved these changes
Dec 9, 2024
edwintorok
reviewed
Dec 9, 2024
It is possible that a XenAPI call to xapi will result in an xmlrpc ProtocolError being returned, typically a 500 Internal Error. As it is not practical to wrap all the calls to xapi via the xenapi session in a specific exception handler add one into the outer run method to ensure that it is converted to an error code and not an unknown error. Signed-off-by: Mark Syms <[email protected]>
KevinLCtx
approved these changes
Dec 9, 2024
edwintorok
approved these changes
Dec 10, 2024
robhoes
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible that a XenAPI call to xapi will result in an xmlrpc ProtocolError being returned, typically a 500 Internal Error. As it is not practical to wrap all the calls to xapi via the xenapi session in a specific exception handler add one into the outer run method to ensure that it is converted to an error code and not an unknown error.