Add udev rules for PureStorage - best practices #729
+18
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit integrates PureStorage-recommended udev rules to optimize queue settings for Citrix XenServer. These changes follow the guidelines outlined in the PureStorage Knowledge Base article [#kbid](https://support.purestorage.com/bundle/m_citrix/page/Solutions/Citrix/Citrix_XenServer/topics/task/t_applying_queue_settings_with_udev.html). Key changes: - Implemented udev rules to adjust IO scheduler and queue depth for PureStorage volumes. - Ensured compliance with existing XenServer storage management (SM) conventions. - Verified functionality through test scenarios to avoid regression with non-PureStorage configurations. Motivation: These changes aim to improve performance and reliability for deployments using PureStorage arrays, adhering to vendor-recommended best practices while maintaining compatibility with the broader XenServer ecosystem. Testing: - Manually verified udev rules on test systems with PureStorage arrays. - Confirmed compatibility with non-PureStorage environments. - Ran unit tests for related storage subsystems. This change is backward-compatible, introduces no breaking changes and only affect PureStorage arrays. Signed-off-by: Yann LE BRIS <[email protected]>
ylebris
force-pushed
the
upstream-iscsi-optimization-purestorage
branch
from
83bc183 to
bfbb200
Compare
ylebris
changed the title
|
@MarkSymsCtx ready to be reviewed |
|
I would much rather see this submitted to XenServer from Pure themselves through our Partner relationship team than to take an essentially random PR that we are unable to test. |
|
Hi It's not a random PR, Yann is working at Vates. Also, the PR points to the reference from Pure Storage. If you want someone from Pure to write a message in here, this is doable. Thanks for reviewing the PR. |
|
The kbid make no mention of modifying the udev rules for DM devices only for the sd devices that match the PURE vendor. |
MarkSymsCtx
reviewed
Jan 24, 2025
Signed-off-by: Yann LE BRIS <[email protected]>
ylebris
force-pushed
the
upstream-iscsi-optimization-purestorage
branch
from
21822da to
cefeb90
Compare
|
@MarkSymsCtx you can review again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit integrates PureStorage-recommended udev rules to optimize queue settings for Citrix XenServer. These changes follow the guidelines outlined in the PureStorage Knowledge Base article #kbid.
Key changes:
Motivation:
These changes aim to improve performance and reliability for deployments using PureStorage arrays, adhering to vendor-recommended best practices while maintaining compatibility with the broader XenServer ecosystem.
Testing:
This change is backward-compatible, introduces no breaking changes and only affect PureStorage arrays.