Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up appcenter-analytics #1759

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Clean up appcenter-analytics #1759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f0ce59f
clean up AppCenterAnalytics
UjuiUjuMandan Jan 3, 2025
0a0adff
skip importing appcenter-analytics
UjuiUjuMandan Jan 3, 2025
a660bc5
remove analytics from AppCenter.start
UjuiUjuMandan Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ dependencies {

// 应用服务分发
def appCenterSdkVersion = '4.4.5'
implementation "com.microsoft.appcenter:appcenter-analytics:${appCenterSdkVersion}"
// implementation "com.microsoft.appcenter:appcenter-analytics:${appCenterSdkVersion}"
// implementation "com.microsoft.appcenter:appcenter-crashes:${appCenterSdkVersion}"
implementation "com.microsoft.appcenter:appcenter-distribute:${appCenterSdkVersion}"

Expand Down
2 changes: 0 additions & 2 deletions app/src/main/java/com/hippo/ehviewer/ui/scene/gallery/detail/GalleryDetailScene.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,6 @@
import com.hippo.ehviewer.ui.scene.history.HistoryScene;
import com.hippo.ehviewer.ui.scene.TransitionNameFactory;
import com.hippo.ehviewer.ui.scene.gallery.list.GalleryListScene;
import com.hippo.ehviewer.util.AppCenterAnalytics;
import com.hippo.ehviewer.util.ClipboardUtil;
import com.hippo.ehviewer.widget.ArchiverDownloadProgress;
import com.hippo.ehviewer.widget.GalleryRatingBar;
Expand Down Expand Up @@ -461,7 +460,6 @@ public void onCreate(@Nullable Bundle savedInstanceState) {
properties = new HashMap<>();
properties.put("Title", mGalleryInfo.title);
properties.put("Time", dateFormat.format(date));
AppCenterAnalytics.trackEvent("进入画廊详情页", properties);
}

torrentDownloadHandler = new TorrentDownloadHandler();
Expand Down
2 changes: 0 additions & 2 deletions app/src/main/java/com/hippo/ehviewer/ui/splash/SplashActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import com.hippo.ehviewer.ui.EhActivity
import com.hippo.ehviewer.ui.MainActivity
import com.hippo.ehviewer.ui.dialog.EhDistributeListener
import com.microsoft.appcenter.AppCenter
import com.microsoft.appcenter.analytics.Analytics
import com.microsoft.appcenter.distribute.Distribute
import java.lang.Exception

Expand All @@ -34,7 +33,6 @@ class SplashActivity : EhActivity() {
}
AppCenter.start(
application, "a47010fb-702a-415a-ad93-ab5c674093ca",
Analytics::class.java, Distribute::class.java
)
// AppCenter.start(getApplication(), "feb52710-e245-4820-aebb-a57e00ed806d",
// Analytics.class, Crashes.class, Distribute.class);
Expand Down
32 changes: 0 additions & 32 deletions app/src/main/java/com/hippo/ehviewer/util/AppCenterAnalytics.java
View file
Open in desktop

This file was deleted.

Loading