Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #294 #295

Merged
merged 3 commits into from
Oct 17, 2023
Merged

Closes #294 #295

merged 3 commits into from
Oct 17, 2023

Conversation

RaphaelS1
Copy link
Collaborator

No description provided.

@RaphaelS1 RaphaelS1 requested a review from bblodfon October 17, 2023 14:01
Copy link
Collaborator

@bblodfon bblodfon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a small fix, good to merge

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a63ed55) 88.71% compared to head (032f62d) 88.71%.
Report is 5 commits behind head on main.

❗ Current head 032f62d differs from pull request most recent head e2f2235. Consider uploading reports for the commit e2f2235 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #295   +/-   ##
=======================================
  Coverage   88.71%   88.71%           
=======================================
  Files         112      112           
  Lines        9120     9122    +2     
=======================================
+ Hits         8091     8093    +2     
  Misses       1029     1029           
Files Coverage Δ
R/SDistribution_Arrdist.R 84.61% <100.00%> (+0.10%) ⬆️
R/SDistribution_Matdist.R 90.47% <100.00%> (+0.09%) ⬆️
R/merge_cols.R 53.84% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RaphaelS1 RaphaelS1 merged commit 255a666 into main Oct 17, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

survival property disappears after combining VectorDistributions
2 participants