Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Some improvements for Xavier #2777

Merged
merged 7 commits into from
Jan 24, 2025
Merged

Conversation

ChengjieLi28
Copy link
Contributor

@ChengjieLi28 ChengjieLi28 commented Jan 22, 2025

  1. Xavier supports model recovery. Due to the special nature of rank 0, a separate, simple model actor is created for rank 0. This actor is responsible only for constructing the collective communication world. A new role, collective_manager, is introduced. In the recovery logic, the collective_manager instructs all ranks to reconstruct the collective communication world.
  2. If an error occurs during the transmission process (e.g., the sender is undergoing recovery), vllm's scheduling supports rollback, where it reverts to forcing computation instead of transmission.
  3. Xavier's transmission process only applies to the PREFILL stage, and no data transmission occurs during the DECODE stage. This is because data transmission in the DECODE stage only affects the last token of a block when it is about to be filled with tokens. This would be counterproductive and negatively impact overall throughput, as it introduces additional RPC call times for many queries.
  4. Fix the error when multiple models are enabled with Xavier simultaneously. This is because the block tracker should be one-to-one with the model, rather than having just one block tracker for all models.

@XprobeBot XprobeBot added the enhancement New feature or request label Jan 22, 2025
@XprobeBot XprobeBot added this to the v1.x milestone Jan 22, 2025
@ChengjieLi28 ChengjieLi28 marked this pull request as ready for review January 23, 2025 07:38
Copy link
Contributor

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye qinxuye merged commit 121c08a into xorbitsai:main Jan 24, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants