FEAT: create_embedding add field model_replica #2779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
qinxuye
reviewed
Jan 23, 2025
| @@ -693,7 +693,8 @@ def base64_to_image(base64_str: str) -> Image.Image: | |||
| if not is_bge_m3_flag_model and not kwargs.get("return_sparse") | |||
| else "dict" | |||
| ), | |||
| model=self._model_uid, | |||
| model="", | |||
There was a problem hiding this comment.
How about just let the model be the model name? Empty looks weird, what's you opinion? @codingl2k1 @amumu96
There was a problem hiding this comment.
We cann't get model name in here, only replica name. We need to change create_embedding_model_instance and trans origin_uid into EmbeddingModel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.