Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating GitHub workflows to use newer gcc #509

Merged
merged 3 commits into from
Jan 9, 2025
Merged

Updating GitHub workflows to use newer gcc #509

merged 3 commits into from
Jan 9, 2025

Conversation

thjsal
Copy link
Contributor

@thjsal thjsal commented Jan 9, 2025

As discussed in #506, newer gcc version is needed for the GitHub Action workflows when installing X-PSI, because the latest default Ubuntu version has upgraded and has no gcc-10 anymore.

@thjsal thjsal added the bugfix label Jan 9, 2025
@thjsal thjsal requested a review from drannawatts January 9, 2025 21:23
@thjsal
Copy link
Contributor Author

thjsal commented Jan 9, 2025

Everything seems to be working now. I also added python version 3.12 to be one of your testing versions.

Copy link
Member

@drannawatts drannawatts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK great! Into the future we go.....

@thjsal thjsal merged commit 368f5f8 into main Jan 9, 2025
5 checks passed
@thjsal thjsal deleted the thjsal-patch-1 branch January 10, 2025 07:06
thjsal added a commit that referenced this pull request Jan 10, 2025
* Change to gcc-12 for CI tests

* Do testing also with Py3.12

* Use gcc-12 in build_docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants