Automatic dark mode #61
Conversation
|
I tried deploying the website with |
|
Also found this: alex-shpak/hugo-book#151 |
|
It seems to work with the latest code but not v8 release. |
|
Maybe https://github.com/alex-shpak/hugo-book could be a submodule to make updates easier |
|
Looks like this commit removed the submodule be09c54 to allow template tweaks. @manuelvsousa any ideas how to enable dark mode? |
|
Maybe if the "book" theme was forked |
|
Should work now :D |
|
Yeah, sorry. I should have the theme update strategy documented in the README. The theme is not a submodule because we made changes to it, so the only way is to manually merge the future versions of the theme and solve any conflicts. What we could do is add the theme as a subtree which will help in future updates. I can take this one, and apply the correct strategy. About the dark theme. I have mixed feelings. Firstly, It's not part of the hugo-book core theme so it's not merged in release tags (we are using v8 I believe). Second, as a dark theme user, I tested the dark theme and it's a bit ugly :C We are using tables, emojis, snippets, and colored shortcodes that don't adapt with the dark color and makes it harder to read. The biggest problem is that I can't go back to the light color because my browser is marked as dark default :S |
|
The css for theme-dark could be edited to make it look better. |
Sure :D If you have the time and the will go ahead, you have my support! Let's just make sure we don't make this into something that will annoy the reader. Colours are not our biggest priority. I would also wait until PR #66 and #65 get sorted out (See #66 (comment)). |
|
@manuelvsousa it is apart of the hugo-book repo alex-shpak/hugo-book@4e34988 its just not in a release yet. This PR maybe pointless if your getting the new commits from alex-shpak/hugo-book. I might be able to create a toggle but not make it look nice :/ |
|
I believe the author said it's not going to make it into the core theme (alex-shpak/hugo-book#59 (comment)) We can make custom changes, and we already did. If we want to update to future versions of the theme we can just pull the subtree, merge the new files and everything should work just fine. Unless change core stuff we are not going to have a lot of problems. |
|
That was last year and dark mode has been removed from the plugins list |
|
I will wait for #66 before continuing as this uses the new code from the theme. (This PR does work currently) |
https://themes.gohugo.io/hugo-book/#site-configuration
Pointless but great.