Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing issue #601 #624

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fixing issue #601 #624

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0d1292f
fixing issue #601
SanjanaSogimatt Jan 4, 2025
d91c1cd
refactor: remove getMetaConfigFromTitle lookup from _meta.tsx files
printerscanner Jan 13, 2025
dee3f99
Revert "refactor: remove getMetaConfigFromTitle lookup from _meta.tsx…
printerscanner Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions sites/reactflow.dev/src/pages/learn/advanced-use/_meta.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { getMetaConfigFromTitleLookup } from 'xy-shared';

const titleLookup = {
export default {
accessibility: 'Accessibility',
testing: 'Testing',
typescript: 'TypeScript',
Expand All @@ -11,4 +10,4 @@ const titleLookup = {
'devtools-and-debugging': 'Devtools',
};

export default getMetaConfigFromTitleLookup(titleLookup, '/learn/advanced-use');

5 changes: 2 additions & 3 deletions sites/reactflow.dev/src/pages/learn/concepts/_meta.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
import { getMetaConfigFromTitleLookup } from 'xy-shared';

const titleLookup = {
export default {
introduction: 'Introduction',
'terms-and-definitions': 'Terms and Definitions',
'core-concepts': 'Core Concepts',
'the-viewport': 'The Viewport',
'built-in-components': 'Built-In Components',
};

export default getMetaConfigFromTitleLookup(titleLookup, '/learn/concepts');

9 changes: 3 additions & 6 deletions sites/reactflow.dev/src/pages/learn/customization/_meta.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { getMetaConfigFromTitleLookup } from 'xy-shared';

const titleLookup = {

export default {
'custom-nodes': {
title: 'Custom Nodes',
theme: {
Expand Down Expand Up @@ -29,7 +29,4 @@ const titleLookup = {
},
};

export default getMetaConfigFromTitleLookup(
titleLookup,
'/learn/customization',
);

7 changes: 1 addition & 6 deletions sites/reactflow.dev/src/pages/learn/getting-started/_meta.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,7 @@
import { getMetaConfigFromTitleLookup } from 'xy-shared';

const titleLookup = {
export default {
'installation-and-requirements': 'Installation',
'building-a-flow': 'Building a Flow',
'adding-interactivity': 'Adding Interactivity',
};

export default getMetaConfigFromTitleLookup(
titleLookup,
'/learn/getting-started',
);
5 changes: 2 additions & 3 deletions sites/reactflow.dev/src/pages/learn/layouting/_meta.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
import { getMetaConfigFromTitleLookup } from 'xy-shared';

const titleLookup = {
export default {
layouting: 'Layouting Libraries',
'sub-flows': 'Sub-Flows',
};

export default getMetaConfigFromTitleLookup(titleLookup, '/learn/layouting');

8 changes: 2 additions & 6 deletions sites/reactflow.dev/src/pages/learn/troubleshooting/_meta.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { getMetaConfigFromTitleLookup } from 'xy-shared';

const titleLookup = {

export default {
index: 'Common Errors',
'remove-attribution': 'Remove Attribution',
'migrate-to-v12': 'Migrate to v12',
Expand All @@ -13,7 +13,3 @@ const titleLookup = {
},
};

export default getMetaConfigFromTitleLookup(
titleLookup,
'/learn/troubleshooting',
);