Move off of #[start] for no_std tests #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We also probably shouldn't be doing this for no_std tests anyway. There are other ways to achieve this IIRC; the only reason we're forced to do no_std binary stuff is because tests need to execute. Not a problem with |
Manishearth
force-pushed
the
no-std-tests
branch
2 times, most recently
from
c37be44 to
6f442a7
Compare
|
There was no need to run fancy ui tests in no std mode. I cleaned all that up and moved to a separate no_std test. We no longer need unstable features for our tests. (We still run uitests on nightly because we check in golden error messages) |
Manishearth
force-pushed
the
no-std-tests
branch
3 times, most recently
from
3698745 to
09590dd
Compare
Manishearth
force-pushed
the
no-std-tests
branch
from
09590dd to
dfa2f85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54