Feat: Support KRM input #170
Conversation
| @@ -46,6 +49,26 @@ func processResults(cancel context.CancelFunc, o output.Output, validationResult | |||
| return result | |||
| } | |||
|
|
|||
| func parseStdin(stdin *os.File) *strings.Reader { | |||
There was a problem hiding this comment.
would be awesome if this could take a reader and return a reader
| rl, err := fn.ParseResourceList([]byte(content)) | ||
| // If it's ResourceList, use the items as the new content. | ||
| if err == nil { | ||
| content = rl.Items.String() |
There was a problem hiding this comment.
That's one part I'm worried about... there are some ridiculous optimisations to ensure we read stdin as a stream, and from previous tickets it looks like some people do indeed pass very large amounts of data via stdin... if we were to do that, this function would have to operate on a stream without buffering the whole thing
| } | ||
|
|
||
| // Check if the stdin input is ResourceList. | ||
| rl, err := fn.ParseResourceList([]byte(content)) |
There was a problem hiding this comment.
This adds support for ResourceLists (I need to read about this) only if passed via stdin? This would not work if I ran kubeconform ./fixtures/krm.yaml? I think we would need some consistency there
|
Lots of questions I'm sorry :D There is also a Spec for the ResourceList type itself here: https://github.com/kubernetes-sigs/kustomize/blob/master/cmd/config/docs/api-conventions/functions-spec.md do we want to validate both the ResourceList itself AND the resources? |
|
@yannh this implementation is just a PoC so no need to give it much attention per se 😅 In general I find the current approach I proposed is not the best because:
So I suggest splitting that functionality to a different code which will import kubeconform instead of being embedded in it. The question now is, do you like to add it as a part of this repo (kubeconform), or I just create a separate repo for it? |
|
Closing this PR in favor of #189 |
This is a quick PoC to support KRM as an input Kubeconform (the implementation is not final, but as mentioned in #160 just to show the idea).
To test the feature:
The output will look like this:
This shows that Kubeconform validated the items inside the KRM resource named krm-function-input.