Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the security policy proposal order and add security one #108

Merged
merged 4 commits into from
Jan 5, 2024

Conversation

teclator
Copy link
Contributor

Problem

The security policy is run after the software one adding the firewalld package as needed but it is not shown until next run of the proposal because the order and also the security proposal is not shown.

Solution

In AutoYaST run the security proposal before the software one although it is shown later and also add the security proposal allowing the user to disable the firewall although it is something that could be done through the profile

Testing

  • Tested manually

Screenshots

If the fix affects the UI attach some screenshots here.

@teclator teclator marked this pull request as draft October 30, 2023 09:30
@teclator teclator marked this pull request as ready for review November 2, 2023 10:02
@teclator teclator changed the title [WIP] Security policy order Modify the security policy proposal order and add security one Nov 2, 2023
Copy link
Contributor

@imobachgs imobachgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teclator teclator merged commit c4ffa82 into SLE-15-SP5 Jan 5, 2024
2 checks passed
@teclator teclator deleted the security_policy_order branch January 5, 2024 11:07
@yast-bot
Copy link

yast-bot commented Jan 5, 2024

✔️ Internal Jenkins job #761 successfully finished
✔️ Created IBS submit request #316865

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants