Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kdump is currently not compatible with Systemd Boot #138

Merged
merged 14 commits into from
Jun 21, 2024
Merged

Conversation

schubi2
Copy link
Member

@schubi2 schubi2 commented Jun 19, 2024

Problem

mkdumprd produces an error while installation if kdump is used together with systemd-boot.

Solution

Do not propose Kdump if systemd-boot is used for bootloader.
If the user still insists on using Kdump he will get a warning but can continue.

It seems that the Kdump scripts have problems with systemd-boot. See
https://bugzilla.opensuse.org/show_bug.cgi?id=1226676

We are aware that this PR is temporary only until Kdump fixed. But meanwhile we should inform the user
that there could be a problem here. Currently we are already tell the user in YaST that systemd-boot
is in the evaluation state if he is selecting it for bootloader.

Testing

  • Tested manually

@jiribohac
Copy link
Contributor

Why don't we fix the kdump/systemd-boot incompatibility instead?
Could you share more about the problem, I don't know anything about it? bsc?

@jiribohac
Copy link
Contributor

Please report the problem in bugzilla and let's work to fix this in kdump or systemd-boot or both.
I think adding such workaround into yast2-kdump is not a good idea We need to fix the problem. If it's not possible, we could also easily prevent concurrent installation of kdump and systemd-boot by simply adding a Conflicts: into one of the packages' spec file.

@coveralls
Copy link

Coverage Status

coverage: 40.099% (-0.01%) from 40.11%
when pulling 11f7136 on systemd-boot
into 6d275f8 on master.

@schubi2
Copy link
Member Author

schubi2 commented Jun 20, 2024

Please report the problem in bugzilla and let's work to fix this in kdump or systemd-boot or both. I think adding such workaround into yast2-kdump is not a good idea We need to fix the problem. If it's not possible, we could also easily prevent concurrent installation of kdump and systemd-boot by simply adding a Conflicts: into one of the packages' spec file.

Yes, I will create a bugzilla entry but fixing Kdump is not so easy because currently the Kdump scripts does not support systemd-boot. Solving it via package dependencies would come to the same solution as this PR has already.
We are at the beginning of systemd-boot. Currently we are collecting more or less "problems" in TW. So this fix is temporary only and should only inform the user that there could be a problem but it would be not fair if we are not giving this information to the user. Our aim is that other users are "playing" with systemd-boot in TW :-)

@coveralls
Copy link

Coverage Status

coverage: 40.556% (+0.4%) from 40.11%
when pulling 0690fa8 on systemd-boot
into 6d275f8 on master.

src/modules/Kdump.rb Outdated Show resolved Hide resolved
@coveralls
Copy link

Coverage Status

coverage: 40.556% (+0.4%) from 40.11%
when pulling 6b280e2 on systemd-boot
into 6d275f8 on master.

@coveralls
Copy link

Coverage Status

coverage: 40.556% (+0.4%) from 40.11%
when pulling cd48f56 on systemd-boot
into 6d275f8 on master.

@coveralls
Copy link

Coverage Status

coverage: 40.556% (+0.4%) from 40.11%
when pulling b4fe5f6 on systemd-boot
into 6d275f8 on master.

@jreidinger jreidinger merged commit 6f0832b into master Jun 21, 2024
12 checks passed
@jreidinger jreidinger deleted the systemd-boot branch June 21, 2024 10:47
@yast-bot
Copy link
Contributor

❌ Internal Jenkins job #38 failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants