Don't Add Empty fadump="" Kernel Parameter [SLE-15-SP7] #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't Add Empty fadump="" Kernel Parameter [SLE-15-SP6]
jreidinger
approved these changes
Sep 18, 2024
|
✔️ Internal Jenkins job #3 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Target Branch
This merges #141 to SLE-15-SP7.
Bugzilla
https://bugzilla.suse.com/show_bug.cgi?id=1230359
Problem
On the PPC64 architecture, when fadump (Firmware Assisted Dump) kernel dumps are supported, but the user chooses not to enable that in the YaST UI, the
fadumpkernel parameter is still added, albeit with an empty argument:This does not really do any harm, but user scripts that check for this kernel parameter may be confused.
Fix
Don't add this parameter if its argument is empty. If it's already there, but empty, remove it with the special
:missingargument.Test
Hacked up a (x86_64) TW VM: Moved away the original
kdumptooland replaced it with a shell script that writes the values from https://bugzilla.suse.com/show_bug.cgi?id=1230359#c12 to stdout to mock fadump support.Manual test with
yast2 bootloaderandyast2 kdump.Checked the original kernel parameters in
/etc/default/gruband in/boot/grub2/grub.cfgDouble-checked the kernel parameters with
yast2 bootloaderStarted
yast2 kdump:Checked the kernel parameters again in
/etc/default/gruband in/boot/grub2/grub.cfg: There should now be anfadump="on"parameter.Started
yast2 kdumpagain:/etc/default/gruband in/boot/grub2/grub.cfg: There should now not anfadump="parameter.Edited
/etc/default/gruband added an emptyfadump=parameterStarted
yast2 kdumpagain:/etc/default/gruband in/boot/grub2/grub.cfg: There should now not anfadump="parameter despite the manually added one.Related PRs