-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guard secret attributes against leaking to the logs [SLE-15-SP6] #1365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guard secret attributes against leaking to the logs [SLE-15-SP2]
Guard secret attributes against leaking to the logs [SLE-15-SP3]
Guard secret attributes against leaking to the logs [SLE-15-SP4]
Guard secret attributes against leaking to the logs [SLE-15-SP5]
shundhammer
force-pushed
the
huha-pw-leak-15-6
branch
from
March 13, 2024 16:29
5ee4228
to
b3597d3
Compare
teclator
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
✔️ Internal Jenkins job #6 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Target Branch
This is the merge PR of #1364 to SLE-15-SP6.
Bugzilla
https://bugzilla.suse.com/show_bug.cgi?id=1221194
Trello
https://trello.com/c/6SAaaYZ3/
Problem
Secret attributes of the wifi connection object might leak to the logs, e.g. if methods like
inspect()
are used.Solution
Mark them as secret with
secret_attr
fromYaST2::SecretAttributes
.Test
Related PRs